Skip to content

Fix dangling Lua enum helper calls - #1293

Merged
Frotty merged 1 commit into
masterfrom
codex/fix-lua-forforce-helper
Sep 4, 2026
Merged

Fix dangling Lua enum helper calls#1293
Frotty merged 1 commit into
masterfrom
codex/fix-lua-forforce-helper

Conversation

@Frotty

@Frotty Frotty commented Sep 4, 2026

Copy link
Copy Markdown
Member

Summary

  • use WC3's native enum accessors while Lua context collectors are executing inside native callbacks
  • avoid dangling references to separately garbage-collected __wurst_GetEnum* helpers
  • cover force, group, item, and destructable collector output

Acceptance criteria

  • ForForce works when user code does not otherwise reference GetEnumPlayer
  • generated context collectors contain no hidden dependency on separately emitted helper functions
  • override-aware helpers remain available for replayed callbacks that call GetEnum*

Checks

  • focused Lua callback-helper regression set: passed
  • LuaTranslationTests: passed
  • full test suite: passed (completed before the request to leave the full suite to CI)
  • git diff --check: passed

Known gaps

  • no Warcraft III client run; generated Lua and Lua runtime tests cover this compiler-emission defect

@Frotty

Frotty commented Sep 4, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-04T15:50:55.967105Z ebe2658 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: ebe26587a2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Frotty
Frotty merged commit f20350b into master Sep 4, 2026
3 checks passed
@Frotty
Frotty deleted the codex/fix-lua-forforce-helper branch September 4, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant